Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow vaults and items with brackets #10

Closed
wants to merge 1 commit into from

Conversation

amontalban
Copy link

We are having issues when using this action because we have brackets in our vault and items names:

##[debug]/usr/bin/bash --noprofile --norc -e -o pipefail /home/runner/work/_temp/1afdd4f7-f7cf-41ca-a690-fbc13169b563.sh
Populating variable: SENTRY_AUTH_TOKEN
Getting vault ID from vault name: [STAGE] - Secrets
curl: (22) The requested URL returned error: 400 Bad Request
Could not find vault ID for vault: 
Error: Process completed with exit code 1.

So, this leverages on cURL feature to perform URL-encoding as described here.

I tested it with our own vaults and secrets, but it should cover other cases as well.

@edif2008
Copy link
Member

Hey there.
Thank you for helping us in making this GitHub Action better.

We're currently working on this PR that enhances the way secrets are loaded. With that, we remove the curl commands that were used to fetch the secrets.

Would that approach address your issue as well?

@edif2008
Copy link
Member

edif2008 commented Jul 7, 2023

Closing this PR for the following reasons:

  • Brackets are considered illegal characters according to the secret reference syntax rules.
  • This can be mitigated by using item/vault IDs instead of names.

@edif2008 edif2008 closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants