-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random failures #2
Comments
Hey @amontalban Wow that's interesting, never seen that before. Happy to add some retry functionality to the action. If you're comfortable doing it, feel free to open a PR. Otherwise I'll most likely pick this up next week. Cheers |
Hey @mcmarkj, Thank you for your response, and sorry for my delay I was on vacation last week. Unfortunately, my Typsecript knowledge is minimum so I don't know how to help on this, sorry. But please let me know if I can help somehow. Thanks! |
Hi @mcmarkj, I think that the root cause is that when you start the Unfortunately, we switched to https://github.com/1Password/load-secrets-action repository (which had another issue that I fixed in 1Password/load-secrets-action#10), but I added this as a prior step to make sure the API is in sync before trying to use it.
So maybe you can add a check for that before trying to access it's data. Thank you! |
Hey @amontalban That's really interesting, that sounds more like an issue with the implementation of the connect API than necessarily this Github Action having a bug etc. I guess that curl you are running could be run before you use this action and that would have resolved your issue? Regardless, I do think a retry option sounds like a nice bit of functionality, so think it's worth keeping this issue open and implementing it when I get a chance. Hope you have success with the other action and thanks again for your feedback 😄 |
I'm going to close this issue as I believe it's down to how you've implemented the connect API. |
Hi @mcmarkj !
Thank you for writing this action, it is really helpful.
We are running the 1Password connector inside the workflow by doing this in a previous step:
And then using your action with:
It works most of the time, however in some cases it fails with this error:
How hard would it be to have some sort of retry? Unfortunately, we cannot use this action to retry https://github.com/nick-fields/retry like we do with other commands.
Thank you in advance!
The text was updated successfully, but these errors were encountered: