Conversation
SantiagoPittella
force-pushed
the
santiagopittella-fix-block-tracing
branch
from
81c5116 to
aa23962
Compare
SantiagoPittella
requested review from
Mirko-von-Leipzig,
PhilippGackstatter,
bobbinth and
igamigo
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! Would be cool to test this with the node and validate that the inputs don't grow linearly
| } | ||
|
|
||
| #[test] | ||
| fn prune_to_removes_tracked_blocks() { |
There was a problem hiding this comment.
Not sure if it's simple enough but could also check that the MMR's internal node count decreases when pruning.
There was a problem hiding this comment.
I added assert!(!blockchain.mmr().is_tracked(i as usize)); checks
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
|
Should the |
Oh yes, on it. |
|
@bobbinth we should make a new release after this PR. |
|
Apparently in #2338 the changelog conflicts weren't fixed properly and now reflects changes from the 0.14 version (without the actual implementation). I fixed it in the last commit. |
5 participants
No description provided.