feat: `NetworkAccountTarget` helpers in `miden::standards` by mmagician · Pull Request #2338 · 0xMiden/protocol

mmagician · 2026-01-24T14:36:47Z

Create two MASM helper procedures under a new miden::standards::attachment::network_account_target:

new_attachment(account_id_prefix, account_id_suffix, exec_hint) -> NOTE_ATTACHMENT
get_id(NOTE_ATTACHMENT, NOTE_METADATA_HEADER) -> account_id_prefix, account_id_suffix

closes #2337

crates/miden-standards/src/note/network_account_target.rs

bobbinth

Looks good! Thank you! I reviewed only the non-test code and left a couple of small comments inline.

crates/miden-standards/asm/standards/attachments/network_account_target.masm

crates/miden-standards/asm/standards/attachment/network_account_target.masm

PhilippGackstatter

Looks good!

I left a few suggestions.

crates/miden-standards/asm/standards/attachment/network_account_target.masm

crates/miden-standards/asm/standards/attachments/network_account_target.masm

crates/miden-standards/asm/standards/attachment/network_account_target.masm

bobbinth

Looks good! Thank you! I left a couple of comments inline.

Not for this PR, but we should also create documentation for the standards - similar to how we have docs for the protocol functionality. Let's create an issue for this.

bobbinth · 2026-01-27T00:53:26Z

CHANGELOG.md


+# 0.13.3 (TBD)
+
+- Added standards for working with `NetworkAccountTarget` attachments ([#2338](https://github.com/0xMiden/miden-base/pull/2338)).


If we want this to go into the v0.13.x release, we should change the PR target to main. Otherwise, we should move the changelog entry into the v0.14.0 section.

changed to main and rebased 👍🏼

PhilippGackstatter

Looks good to me!

Left two comments regarding validation and moving MASM tests to miden-testing.

PhilippGackstatter · 2026-01-27T07:57:24Z

crates/miden-protocol/asm/protocol/note.masm

+    u32split
+    # => [attachment_kind, attachment_scheme]


We should probably validate attachment_kind as well here, i.e.:

https://github.com/0xMiden/miden-base/blob/fda68e1008f8b7b7633b8c3dfc6a0fe4e150dd32/crates/miden-protocol/asm/kernels/transaction/lib/output_note.masm#L375-L378

And looking at the neighboring extract_sender_from_metadata, it doesn't validate the account ID which it probably should also do. Would you mind adding a account_id::validate line there and add a Panics if section? If not, lmk and I'll open an issue or address it.

In general, I think the procedures we provide should provide as much safety as they can and if users want to work with potentially invalid metadata, they likely know what they're doing and can write their own procedures. But for 95% of users, validation should be the safer option.

opened an issue: #2349

crates/miden-standards/src/note/network_account_target.rs

Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>

instead of the whole METADATA word, pass only scheme and kind

move under miden-testing/src/standards

PhilippGackstatter

Looks great, thank you for moving the tests to miden-testing🙏

mmagician force-pushed the mmagician-network-target-helpers branch 2 times, most recently from a429f13 to 39c3b41 Compare January 24, 2026 14:48

mmagician commented Jan 24, 2026

View reviewed changes

crates/miden-standards/src/note/network_account_target.rs Outdated Show resolved Hide resolved

mmagician requested a review from PhilippGackstatter January 24, 2026 14:55

mmagician marked this pull request as ready for review January 24, 2026 15:02

bobbinth approved these changes Jan 25, 2026

View reviewed changes

crates/miden-standards/asm/standards/attachments/network_account_target.masm Outdated Show resolved Hide resolved

crates/miden-standards/asm/standards/attachment/network_account_target.masm Outdated Show resolved Hide resolved

bobbinth mentioned this pull request Jan 25, 2026

feat(AggLayer): B2AGG note consumption check #2334

Merged

PhilippGackstatter reviewed Jan 26, 2026

View reviewed changes

mmagician requested a review from PhilippGackstatter January 26, 2026 20:23

mmagician changed the base branch from next to main January 26, 2026 20:40

mmagician changed the base branch from main to next January 26, 2026 20:40

bobbinth approved these changes Jan 27, 2026

View reviewed changes

PhilippGackstatter approved these changes Jan 27, 2026

View reviewed changes

mmagician mentioned this pull request Jan 27, 2026

Validate attachment_kind and account_id in metadata extraction helpers #2349

Open

3 tasks

This was referenced Jan 27, 2026

[WIP] Validate attachment_kind and account_id in metadata extraction helpers #2350

Closed

Validate metadata extraction helpers #2351

Closed

mmagician and others added 14 commits January 27, 2026 10:25

feat: get_id network acc target util

98b8841

chore: rename target_account_id -> account_id

1343b49

feat: add new_attachment helper

fbdcad0

chore: tests for network account target util

296dce2

chore: add a roundtrip test

b02a720

Apply suggestions from code review

9f802c7

Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>

chore: make const public

8704538

chore: add panics & warnings docs

f3b85c0

chore: rename new_attachment -> new

93c1c52

chore: "new" returns scheme and kind

6dc32f6

feat: extract_attachment_info_from_metadata in note.masm

7ab2838

chore: use extract_attachment_info_from_metadata

a604025

feat: verify attachment kind also

4be5a7f

feat: change get_id to only take necessary inputs

d45d06f

instead of the whole METADATA word, pass only scheme and kind

mmagician added 7 commits January 27, 2026 10:25

lint

b56bff1

changelog

48e7b61

chore: rename attachment -> attachments (plural)

fd706e5

chore: move tests under miden-testing

a3e1177

move under miden-testing/src/standards

chore: change stack comparison to word

76cf85a

chore: use doc comments

1860fe4

chore: remove tokio dep from miden-testing

d01e1cf

mmagician changed the base branch from next to main January 27, 2026 10:26

mmagician force-pushed the mmagician-network-target-helpers branch from 59052a4 to d01e1cf Compare January 27, 2026 10:26

mmagician requested a review from PhilippGackstatter January 27, 2026 10:30

PhilippGackstatter approved these changes Jan 27, 2026

View reviewed changes

mmagician merged commit 0a90aeb into main Jan 27, 2026
17 checks passed

mmagician deleted the mmagician-network-target-helpers branch January 27, 2026 16:50

SantiagoPittella mentioned this pull request Jan 27, 2026

fix: track block in MMR #2353

Merged

mmagician mentioned this pull request Feb 1, 2026

Create network target account helpers #2337

Closed


		# 0.13.3 (TBD)

		- Added standards for working with `NetworkAccountTarget` attachments ([#2338](https://github.com/0xMiden/miden-base/pull/2338)).

Conversation

mmagician commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

bobbinth Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

mmagician Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

mmagician Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mmagician commented Jan 24, 2026 •

edited

Loading