chore: enforce minimum number of account procedures in tx kernel#2171
Merged
chore: enforce minimum number of account procedures in tx kernel#2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a mismatch between
AccountCodein Rust and the tx kernel in MASM whereAccountCodeenforces that it contains at leastAccountCode::MIN_NUM_PROCEDURES, but the kernel does not. This is a case where Rust rules are stricter than Masm, which shouldn't be the case. We should either be more lenient inAccountCodeor make the tx kernel validate that at least two procedures are present.Since the validation in
AccountCodedoes make sense (an auth procedure is required and a non-auth procedure should be present for the account to be useful), I think the right move is to add a check in the kernel.addresses #2162 (comment)