feat: remove offset and size from AccountProcedureInfo#2162
Merged
Conversation
mmagician
reviewed
Dec 11, 2025
bobbinth
reviewed
Dec 11, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left some comments inline.
…remove-procedure-offset-and-size
…remove-procedure-offset-and-size
2 tasks
bobbinth
approved these changes
Dec 12, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just one comment inline.
mmagician
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
AccountProcedureInfointoAccountProcedureRootand remove storage offset and size.AccountCode::procedures. Happy to bring these back if you have different opinions.mem::pipe_words_to_memoryinstead ofpipe_double_words_to_memoryfor hashing account code. This is less efficient, but I don't think we should enforce that the number of procedures is even?AccountComponentInterface. Then each component corresponded to oneAccountComponentInterface::Customentry. We can no longer differentiate components at the procedure level now, and so all procedures that are not well-known are put into a singleAccountComponentInterface::Custom. Since we want to refactor this anyway, I assume this is not a big deal.This addresses the remaining TODO(named_slots) and so this should close the named storage slots issue.
Follow-up: (note to self) Open issue for rearranging account memory to make all account sections contiguous.
closes #1724