Skip to content

chore: Add serialization for BlockInputs #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbinth merged 1 commit into from
Nov 26, 2025
Merged

chore: Add serialization for BlockInputs #2112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions crates/miden-objects/src/block/block_inputs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
use alloc::collections::BTreeMap;

use miden_core::utils::{ByteReader, ByteWriter, Deserializable, Serializable};

use crate::account::AccountId;
use crate::block::{AccountWitness, BlockHeader, NullifierWitness};
use crate::note::{NoteId, NoteInclusionProof, Nullifier};
use crate::transaction::PartialBlockchain;
use crate::utils::serde::DeserializationError;

// BLOCK INPUTS
// ================================================================================================
Expand Down Expand Up @@ -128,3 +131,35 @@ impl BlockInputs {
&mut self.account_witnesses
}
}

// SERIALIZATION
// ================================================================================================

impl Serializable for BlockInputs {
fn write_into<W: ByteWriter>(&self, target: &mut W) {
self.prev_block_header.write_into(target);
self.partial_blockchain.write_into(target);
self.account_witnesses.write_into(target);
self.nullifier_witnesses.write_into(target);
self.unauthenticated_note_proofs.write_into(target);
}
Comment on lines +139 to +145
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like deconstructing in these type of situations so that one is forced to revisit this if you add a new field

Suggested change
fn write_into<W: ByteWriter>(&self, target: &mut W) {
self.prev_block_header.write_into(target);
self.partial_blockchain.write_into(target);
self.account_witnesses.write_into(target);
self.nullifier_witnesses.write_into(target);
self.unauthenticated_note_proofs.write_into(target);
}
fn write_into<W: ByteWriter>(&self, target: &mut W) {
let Self {
prev_block_header,
partial_blockchain,
account_witnesses,
nullifier_witnesses,
unauthenticated_note_proofs,
} = self;
prev_block_header.write_into(target);
partial_blockchain.write_into(target);
account_witnesses.write_into(target);
nullifier_witnesses.write_into(target);
unauthenticated_note_proofs.write_into(target);
}

Copy link
Contributor Author

@sergerad sergerad Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point, will remember in future

}

impl Deserializable for BlockInputs {
fn read_from<R: ByteReader>(source: &mut R) -> Result<Self, DeserializationError> {
let prev_block_header = BlockHeader::read_from(source)?;
let partial_blockchain = PartialBlockchain::read_from(source)?;
let account_witnesses = BTreeMap::<AccountId, AccountWitness>::read_from(source)?;
let nullifier_witnesses = BTreeMap::<Nullifier, NullifierWitness>::read_from(source)?;
let unauthenticated_note_proofs =
BTreeMap::<NoteId, NoteInclusionProof>::read_from(source)?;

Ok(Self::new(
prev_block_header,
partial_blockchain,
account_witnesses,
nullifier_witnesses,
unauthenticated_note_proofs,
))
}
}
Loading