chore: Add serialization for BlockInputs#2112
Merged
Conversation
sergerad
requested review from
Mirko-von-Leipzig,
PhilippGackstatter and
bobbinth
PhilippGackstatter
approved these changes
Nov 26, 2025
sergerad
added
the
no changelog
Comment on lines
+139
to
+145
| fn write_into<W: ByteWriter>(&self, target: &mut W) { | ||
| self.prev_block_header.write_into(target); | ||
| self.partial_blockchain.write_into(target); | ||
| self.account_witnesses.write_into(target); | ||
| self.nullifier_witnesses.write_into(target); | ||
| self.unauthenticated_note_proofs.write_into(target); | ||
| } |
Contributor
There was a problem hiding this comment.
I like deconstructing in these type of situations so that one is forced to revisit this if you add a new field
Suggested change
| fn write_into<W: ByteWriter>(&self, target: &mut W) { | |
| self.prev_block_header.write_into(target); | |
| self.partial_blockchain.write_into(target); | |
| self.account_witnesses.write_into(target); | |
| self.nullifier_witnesses.write_into(target); | |
| self.unauthenticated_note_proofs.write_into(target); | |
| } | |
| fn write_into<W: ByteWriter>(&self, target: &mut W) { | |
| let Self { | |
| prev_block_header, | |
| partial_blockchain, | |
| account_witnesses, | |
| nullifier_witnesses, | |
| unauthenticated_note_proofs, | |
| } = self; | |
| prev_block_header.write_into(target); | |
| partial_blockchain.write_into(target); | |
| account_witnesses.write_into(target); | |
| nullifier_witnesses.write_into(target); | |
| unauthenticated_note_proofs.write_into(target); | |
| } |
Contributor
Author
There was a problem hiding this comment.
Excellent point, will remember in future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks 0xMiden/node#1381.
Will not merge if it ends up being unnecessary for that node PR.