Conversation
48f8bc5 to
8ea72c3
Compare
before executing them
8ea72c3 to
01f5b50
Compare
bobbinth
approved these changes
Jun 19, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
Collaborator
Author
|
@bobbinth Done. Please do another round. |
bobbinth
approved these changes
Jun 19, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
All looks good! Thank you!
igamigo
reviewed
Jun 19, 2025
igamigo
approved these changes
Jun 20, 2025
Contributor
I'm not sure we need to do anything about this on the client side. In the future, foreign accounts would get processed correctly in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1452
This PR introduces the following changes:
TransactionHost::newnow expects&AccountinsteadAccountHeader.Testing
I tried to test these changes by pulling them through the
miden-client(next branch,v0.10) and patching numerous deps along the way to try it in the test reproduced in #1452 but stumbled upon testnet node rejecting my request because my client is notv0.9. So, no luck.Next, I looked into
miden-testingto introduce a test there, but found that it'd take quite a lot of efforts to construct a proper test case (a note script, loading the data from the advice provider and calling an account that is also loads another data from the advice provider). OTOH, the code changes are quite straightforward, so I'd assume they should work. Please let me know if you want me to build one.