Tracking PR for v0.18.0 release #534
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: check MSRV, add a rust-toolchain file This adds a CI job that will check the MSRV of any PR is set correctly on a crate by crate basis. If the MSRV is set in correctly, due to e.g. some feature used, it will compute the correct MSRV for the user and indicate it in its error. The script's error message and functioning can be emulated by manually changing the MSRV to an incorrect version (e.g. 1.87) and running it (./scripts/check-msrv.sh). This further adds a rust-toolchain file that will make CI follow the latest stable as it updates. As a consequence, the following behaviors can change from being proactive to being on-demand: - bumping the MSRV. As a side effect, we no longer have to bump our MSRV beyond what we actually use, i.e. the MSRV setting accurately reflects what we can compile with. * fix: set a fixed rust version
* feat: extend Merkle tree benchmarks * feat: start Sparse Merkle tree benchmarks * fix: address review comments * refactor: reduce bench boilerplate Consolidated smt-subtree, smt-with-entries to smt, and removed deleted entries in Cargo.toml * fix: black_box unused results * fix: address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.18.0 release.