Validate forest in Mmr::open_at to prevent OOB access #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
added
the
no changelog
bobbinth
reviewed
Sep 30, 2025
bobbinth
reviewed
Sep 30, 2025
bobbinth
approved these changes
Sep 30, 2025
Good to know that i've made a small thing for your project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add a guard ensuring the requested forest does not exceed self.forest before building the Merkle path. This aligns open_at with existing validation in peaks_at and get_delta, and prevents potential out-of-bounds indexing and panics when callers pass an invalid forest.