Add extra unittests for NullPropagation / ToString / AllowEqualsAndToStringMethodsOnObject is true #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StringMethodsOnObject is true
There was a problem hiding this comment.
Pull Request Overview
This PR adds extra unit tests to verify the behavior of null propagation and string conversion when AllowEqualsAndToStringMethodsOnObject is true. It also updates array initialization syntax in tests and refines a pattern match in the expression helper.
- Added two new unit tests for null propagation in QueryableTests.Where.cs.
- Updated array initialization formatting in ExpressionParserTests.cs.
- Replaced a negated type-check with a positive "is not" pattern in ExpressionHelper.cs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/QueryableTests.Where.cs | Added two unit tests for null propagation and ToString conversion handling. |
| test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionParserTests.cs | Reformatted array initialization using new C# syntax. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs | Updated type-check to use the new pattern matching syntax. |
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.