Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the "not in" and "not_in" operators and updates array initializer syntax in test cases according to the latest language updates. Key changes include
- Updating existing tests to use the new square bracket array initializer syntax.
- Adding new tests to verify the correct parsing and behavior of "not in", "not_in", and combined operators.
- Modifying the core parsing logic in ExpressionParser and Tokenizer to handle the new operators.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionParserTests.cs | Updated test array initializers and added new tests for "not in" operator behavior. |
| test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs | Added tests for "not_in" variants and updated assertions with the new syntax. |
| src/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs | Introduced TokenIsIdentifier and TryGetToken to support new operator detection. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs | Revised operator parsing logic to support "in", "not in", and "not_in" expressions. |
This was referenced Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.