[Fix] Fixed null in Parameter and added functionality Binary And and Or with different Types #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 84.07% 84.19% +0.11%
==========================================
Files 25 25
Lines 3090 3131 +41
Branches 449 471 +22
==========================================
+ Hits 2598 2636 +38
+ Misses 364 357 -7
- Partials 128 138 +10
Continue to review full report at Codecov.
|
|
Maybe this could also be included in the nuget ;-) ? |
StefH
changed the title
|
Can this be merged? |
|
I provided some code-review comments, can you please fix ? |
|
Where? I don't see them! |
StefH
requested changes
Jun 1, 2017
| } | ||
|
|
||
| [Fact] | ||
| public void ExpressionTests_Test_BinaryAndOr() |
There was a problem hiding this comment.
Some remarks:
- Does this method also test
OR? Because I only see&? - Rename this method to
ExpressionTests_BinaryAndand alsoExpressionTests_BinaryOr? - Move this method to the correct location (I try to keep a A-Z sorting applied to this test class to keep things organized)
- Also check the result (result0, result1, ...) using Assert, else the unit-test is not complete.
|
Review is requested now, sorry I did not press the button... ;-) |
|
if it's okay, can you merge and create a nuget? |
StefH
approved these changes
Jun 1, 2017
|
1.0.7.2 / 1.0.4.2 added to NuGet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.