Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix157 #158

Merged
merged 1 commit into from
Apr 28, 2018
Merged

Fix157 #158

merged 1 commit into from
Apr 28, 2018

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #158 into master will increase coverage by 0.03%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   82.42%   82.45%   +0.03%     
==========================================
  Files          37       37              
  Lines        3527     3546      +19     
  Branches      488      488              
==========================================
+ Hits         2907     2924      +17     
- Misses        489      491       +2     
  Partials      131      131
Impacted Files Coverage Δ
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 98.05% <87.5%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e7c43...b734e51. Read the comment docs.

@jogibear9988
Copy link
Contributor Author

will create a better fix, wich does not use the tostring of the parameter

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please only change the code for the **While fix? And don't include the ParsingConfig change?

@jogibear9988
Copy link
Contributor Author

are there problems with the parsing config changes? I can rework this, but the other changes are also needed

@StefH
Copy link
Collaborator

StefH commented Apr 27, 2018

No problems. But i need some time to check these config changes and probably also change the version from nuget because its a breaking API change

@jogibear9988
Copy link
Contributor Author

When you look here: https://codeblog.jonskeet.uk/2018/04/13/backward-compatibility-and-overloading/ you'll see, it's really hard to do a change wich will not break in every situation.

But normaly my changes should not be breaking changes, cause I always also created also the Extension Method without the parameter!

@StefH StefH merged commit 85c7cde into zzzprojects:master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants