-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix157 #158
Fix157 #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 82.42% 82.45% +0.03%
==========================================
Files 37 37
Lines 3527 3546 +19
Branches 488 488
==========================================
+ Hits 2907 2924 +17
- Misses 489 491 +2
Partials 131 131
Continue to review full report at Codecov.
|
will create a better fix, wich does not use the tostring of the parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please only change the code for the **While fix? And don't include the ParsingConfig change?
are there problems with the parsing config changes? I can rework this, but the other changes are also needed |
No problems. But i need some time to check these config changes and probably also change the version from nuget because its a breaking API change |
When you look here: https://codeblog.jonskeet.uk/2018/04/13/backward-compatibility-and-overloading/ you'll see, it's really hard to do a change wich will not break in every situation. But normaly my changes should not be breaking changes, cause I always also created also the Extension Method without the parameter! |
No description provided.