Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterized SQL doesn't work for Contains, StartsWith, and EndsWith #247

Closed
BradleyUffner opened this issue Feb 15, 2019 · 8 comments
Closed

Parameterized SQL doesn't work for Contains, StartsWith, and EndsWith #247

BradleyUffner opened this issue Feb 15, 2019 · 8 comments

Comments

@BradleyUffner
Copy link

If I use .Where(config, "ActivityCode==@0", "AB") it works as expected, generating the parameterized value, but .Where(config, "ActivityCode.Contains(@0)", "A") still inlines the value.
@BradleyUffner BradleyUffner mentioned this issue Feb 15, 2019
Closed
@BradleyUffner BradleyUffner changed the title Parameterized SQL doesn't work for Contains, StartsWith, and EndWith Parameterized SQL doesn't work for Contains, StartsWith, and EndsWith Feb 15, 2019
@StefH StefH mentioned this issue Feb 20, 2019
Merged
@StefH
Copy link
Collaborator

StefH commented Feb 20, 2019

A preview NuGet is released: 1.0.10-ci-1959 ; can you test this?

See https://github.com/StefH/System.Linq.Dynamic.Core/wiki/MyGet-preview-versions for details.

@StefH
Copy link
Collaborator

StefH commented Feb 21, 2019

Hello @BradleyUffner ; can you do some tests please?

@BradleyUffner
Copy link
Author

I'll test it as soon as I get out of the meeting I'm in.

@StefH
Copy link
Collaborator

StefH commented Feb 26, 2019

@BradleyUffner Did you have time to verify ?

@BradleyUffner
Copy link
Author

I'm so sorry, The last few days have been really chaotic, and it keeps slipping my mind. I'll do my best to test this tomorrow.

@BradleyUffner
Copy link
Author

BradleyUffner commented Feb 27, 2019 •
edited
Loading

I just finished testing, it seems to be fixed! Thanks! Sorry for the delay in testing.

StefH added a commit that referenced this issue Feb 27, 2019
@StefH
Wrap all constant expressions to fix Parameterized SQL (#247) (#250)
a963fcb 
* Wrap all constant expressions

* fix test
@StefH
Copy link
Collaborator

StefH commented Feb 27, 2019

Thanks for testing; I'll merge code to master.

I keep you informed here when a new NuGet is released.

@StefH StefH closed this as completed Feb 27, 2019
@StefH
Copy link
Collaborator

StefH commented Feb 28, 2019

Official NuGet 1.0.11 is uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefH @BradleyUffner