feat(codex): add Bash PreToolUse graph guidance#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Codex-specific Bash
PreToolUsehook that nudges shell search/read commands toward Gortex graph tools in soft enrich mode only.Changes
PreToolUsehook for^Bash$alongside the existingSessionStarthook.gortex hook --agent=codexthrough a Codex-specific dispatcher.PreToolUsehandling throughModeEnrich, so it emitshookSpecificOutput.additionalContextwithout denying tool calls.--force.SessionStartplus Bash-only softPreToolUsebehavior.Design notes
From the Codex hook behavior spike:
hookSpecificOutput.additionalContext, so this uses the existingHookOutputJSON shape instead of plain stdout guidance.--mode=enrichfor readability, but Codex handling is clamped in code:RunCodexalways callsrunPreToolUse(..., ModeEnrich)and does not read the CLI--modeflag. This keeps Codex soft-only even if the hook command is hand-edited.commandform for the CodexPreToolUsehook. UnlikeSessionStart, this command just invokesgortex hook; it does not rely on POSIX-only shell text likeprintf. A Windows-specificcommand_windowsoverride can be added later if native Windows hook behavior needs it.RunExternalAgent, keeping Gemini / Antigravity lifecycle hook behavior unchanged.Testing
Ran:
go test ./internal/agents/codexgo test ./internal/hooksgo test ./cmd/gortexgit diff --checkChecklist
Meta["methods"]for interfaces (if applicable)EdgeMemberOfedges to their containing type (if applicable)Related to #206