Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] FLAC Track and Disc number switched #387

Closed
dezponia opened this issue Dec 30, 2023 · 1 comment
Closed

[Bug] FLAC Track and Disc number switched #387

dezponia opened this issue Dec 30, 2023 · 1 comment
Labels
state: done Has been fixed or implemented type: bug Something isn't working
Milestone

Comments

@dezponia
Copy link

Description

FLAC Track and Disc number are switched in the "details" view. The values are otherwise correct so most likely its just variables being switched?

Steps to Reproduce

  1. Go to a FLAC track with track and disc tags that displays as track 1001+ in the track list.
  2. Click on the "..." next to the track.
  3. Click on "Details".
  4. Notice how "Disc number" and "Track number" are switched.

Expected Behavior

If the tag is 1004 then track number should be 4 and disc number should be 1.

Screenshots

Album view with track numbers being 1001+
01 Symphony FLAC Track and Disc number switched
Details for track 1004 show disc and track numbers are switched.
02 Symphony FLAC Track and Disc number switched

Device

  • Device: Fairphone 5
  • OS: Android 13
  • Version: Symphony v2023.12.108

Additional Context

I haven't checked but I suspect the behavior is the same for any file using the Vorbis tag format.
Probably related to this change?
c1b01f4

Additional issue that is probably related but maybe should get its own bug ticket: FLAC files that DON'T have a Disc Number tagged just get "?" as in their track number when viewing an album.

Checklist

@dezponia dezponia added the type: bug Something isn't working label Dec 30, 2023
@zyrouge zyrouge added the priority: high High priority label Dec 30, 2023
@zyrouge
Copy link
Owner

zyrouge commented Dec 30, 2023

I messed up, my bad.

@zyrouge zyrouge added this to the v109 milestone Dec 30, 2023
@zyrouge zyrouge added state: done Has been fixed or implemented and removed priority: high High priority labels Dec 31, 2023
@zyrouge zyrouge closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: done Has been fixed or implemented type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants