Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is image download completed #195

Closed
abdellahaski opened this issue Sep 20, 2018 · 5 comments · Fixed by #200
Closed

is image download completed #195

abdellahaski opened this issue Sep 20, 2018 · 5 comments · Fixed by #200

Comments

@abdellahaski
Copy link

is there a way to know when the image load has completed ?
I've tried this:
(load)="onImageLoad($event)
but it's fired before the image download has completed so it's not what I'm looking for

@madoBaker
Copy link
Contributor

should be fixed with latest PR

@abdellahaski
Copy link
Author

Thanks so much, but can I know how I can apply those changes to my ionic project,
should I just edit src/components/img-loader.ts on the plugin directory on my node_modules? or I need to kinda build the module to get an updated dist directory ?
I'm sorry I new here so..

@madoBaker
Copy link
Contributor

npm i -S ionic-image-loader@latest should do it

@madoBaker
Copy link
Contributor

just a side note, unless you're trying to get a hacky fix to a certain module, you never want to edit anything inside the node_modules dir

@abdellahaski
Copy link
Author

Oh thanks man I didn't thought it's updated to npm
Thanks for the advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants