Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infocomplete: Complete filetypes (follow-up) #3218

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

JoeKar
Copy link
Collaborator

@JoeKar JoeKar commented Mar 25, 2024

The first shot of the feature unfortunately completed the *.yaml file names instead of the included filetypes. This will be corrected with this follow up.

Fixes #3215

@JoeKar JoeKar force-pushed the fix/complete-filetype branch from c47830e to 2ea70f5 Compare March 25, 2024 20:12
dmaluka added a commit to dmaluka/micro that referenced this pull request Mar 26, 2024
This typo causes a funny bug: the autodetected filetype for *.jsonnet
files is an empty string instead of "jsonnet".

Even funnier, when autocompleting "set filetype " (with the fix from
PR zyedidia#3218), the first suggested filetype is this empty string.
internal/action/infocomplete.go Show resolved Hide resolved
internal/action/infocomplete.go Outdated Show resolved Hide resolved
JoeKar and others added 2 commits March 26, 2024 19:05
The first shot of the feature unfortunately completed the *.yaml file
names instead of the included filetypes. This will be corrected with
this follow up.
… hint

Co-authored-by: Dmytro Maluka <dmitrymaluka@gmail.com>
@JoeKar JoeKar force-pushed the fix/complete-filetype branch from 2ea70f5 to 9eb93fc Compare March 26, 2024 18:06
@JoeKar JoeKar merged commit 3d7024e into zyedidia:master Mar 27, 2024
3 checks passed
@JoeKar JoeKar deleted the fix/complete-filetype branch March 27, 2024 17:58
dmaluka added a commit that referenced this pull request Mar 28, 2024
This typo causes a funny bug: the autodetected filetype for *.jsonnet
files is an empty string instead of "jsonnet".

Even funnier, when autocompleting "set filetype " (with the fix from
PR #3218), the first suggested filetype is this empty string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filetype autocompletion suggests wrong filetypes
2 participants