Haiku: fix build for ZydisPerfTest.c #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. So while this isn't exactly a mainstream OS that I'd be willing to maintain support for myself, I suppose that I'd be OK to support it on a "may or may not work, PRs welcome" basis as long as it only needs a few ifdefs here and there. What do you think @flobernd? |
|
@athre0z Yes, I agree! |
|
Right, I'm happy to push up fixes as needed. It should match some other OS ifdef anyway. |
|
Cool! I merged the corresponding zycore PR. Can you update the submodule in this PR to latest master in zycore? |
I can later today. You can also edit the PR if you like. |
|
Submodule updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.