fix(ui): refresh node neighbors when opening node panel in zwave graph #4416
+15
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noted in #4409, the network map was previously querying neighbors for all nodes when the graph was rendered, which was inefficient and could cause performance issues. The suggestion was to refresh neighbors for only the specific node when its panel is opened, rather than refreshing all nodes at once.
Solution
This PR implements targeted neighbor refresh by adding a watcher in
NodePanel.vue
that automatically calls thegetNodeNeighbors
API when the node panel is opened. This ensures neighbor information is up-to-date for the node being viewed without the overhead of querying all nodes.Changes
_value
computed property)refreshNodeNeighbors()
method that calls thegetNodeNeighbors
APIBehavior
When a user clicks on a node in the Z-Wave graph to view its details:
getNodeNeighbors
is calledThis approach is more efficient than the previous implementation, as it only queries the Z-Wave controller for the specific node being examined, rather than all nodes in the network.
Testing
Closes #4409
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
224.0.0.251
If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #4412
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.