Replace close button image with xmark SF Symbol in iOS 13#385
Closed
skjiisa wants to merge 1 commit into
Closed
Conversation
|
@zvonicek Can you please merge this? |
Owner
|
I'm actually unsure about this, mainly because the SF Symbol asset would work on iOS 13 only and the not presence of the image might not be noticed by some users of the library, leading to shipping a broken behavior on older operating systems. However, with this year's SPM improvements we should finally be able to bundle resources in a package. I think this is a better way forward. |
thisisaaronland
pushed a commit
to sfomuseum/ImageSlideshow
that referenced
this pull request
Aug 13, 2020
Owner
|
Support for SPM bundle resources comes in #400. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #362
If cloning the repository using Swift Package Manager, the close button image is not downloaded. This replaces the button's image with the
xmarkSF Symbol if the device is running iOS 13 or newer.