Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: treat all warnings as errors except one rule: dead-code #46

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

advancedxy
Copy link
Contributor

This commit try to fix various code/lint issues: unused import, non snake_case variables, unmatched pattern arms etc. After the fix, we can enable treating all warnings as errors.

The purpose of this commit is to reduce the warning logs when building, which is annoying to find the real errors/problems.

This commit try to fix various code/lint issues: unused import, non snake_case variables,
unmatched pattern arms etc. After the fix, we can enable treating all warnings as errors.

The purpose of this commit is to reduce the warning logs when building, which is annoying
to find the real errors/problems.
@zuston zuston merged commit 8808554 into zuston:main Jul 25, 2023
1 check passed
@zuston
Copy link
Owner

zuston commented Jul 25, 2023

Great work. Will you fix all the enum var with camel case type?

@advancedxy
Copy link
Contributor Author

Great work. Will you fix all the enum var with camel case type?

I annotated some of the enum with UPPER_CASES by purpose(#[allow(non_camel_case_types)]), thought it will match the Java's implementation and would be more familiar.

So in my opinion, I am in favor of that style for such enums. However I have no objections if you would like change them with camel cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants