Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar endpoint with static items list #198

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

Dipo-Jaiye
Copy link
Contributor

@Dipo-Jaiye Dipo-Jaiye commented Aug 31, 2021

Description

An endpoint was added to the codebase that responds to GET requests with a json object containing the list of sidebar items offered by the Company Files Managment plugin. When the change goes live, a visit to http://companyfiles.zuri.chat/sidebar will give a JSON response of the sidebar items of the plugin to be displayed by ZC Main.
No new dependencies are required for this change.

Fixes #183

How Has This Been Tested?

With a Node version of 14+,

  • npm run install-setup To install all necessary packages
  • npm run dev To start the server in development mode
  • Visit "http://localhost:5500/sidebar" on the browser to view the JSON response of the sidebar items. Valid JSON was displayed on the browser window with all fields necessary for the sidebar.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no lint warnings

@omzi omzi marked this pull request as ready for review August 31, 2021 19:33
@omzi omzi self-requested a review August 31, 2021 19:34
Copy link
Contributor

@omzi omzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@omzi omzi merged commit 06dbf1f into zurichat:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ndpoint that provides a static list of the sidebar items
2 participants