Improve local config list and set handling #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[e2e/test_config_local_list_get_set.sh] - Add a temporary directory and git init to the test script - Add checks to ensure the output of `gptcommit config list` is valid TOML - Add checks to ensure the default value is returned when deleting a local configuration setting
- Add tests for local list get and set of OpenAI model - Add `get_config_path` function for retrieving either local or user config path - Update `delete` and `set` functions to use `get_config_path` function - Add async-std dependency and update anyhow and async-trait versions [e2e/test_config_local_list_get_set.sh] - Add tests for local list get and set of OpenAI model - Assert that local config set and delete fail when not using --local flag - Assert that local config get returns the correct value after setting and deleting with --local flag [src/actions/config.rs] - Add `async_std::path::Path` to the imports - Change the `get_config_path` function to handle both local and user config paths - Add `get_config_path` function for retrieving either local or user config path - Add error handling to the `delete` and `set` functions for when no config path is found - Update the `delete` and `set` functions to use the `get_config_path` function [Cargo.toml] - Add async-std dependency - Update anyhow and async-trait versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[e2e/test_config_local_list_get_set.sh]
gptcommit config listis valid TOML