feat: Update prompt language settings for summarization

[zcf0508]

#42

Hi, thanks for building this tool!

I'm a Chinese, so I need a configuration to set the language to use when generating the summary, like Chinese.

This is my work. And I am a novice in programming with rust, so if there are any mistakes, welcome to make suggestions.

[zurawiki]

Thanks for the PR. Left some comments.

My main question is what happens when we select an unsupported language? Can we provide a clear list of supported languages?

[zurawiki]

Thanks for the patch. Just some remaining comments and I think we are almost there

[zcf0508]

Hi, I have two problem that I need your help.

① First, about the enum Language. I got wrong result when I use Language::from_str(value) , and the value is the input.

#[derive(Debug, Clone, Copy, PartialEq)]
#[derive(Display, EnumString, IntoStaticStr)]
#[strum(serialize_all = "kebab-case")]
pub enum Language {
   #[strum(to_string = "English")]
   En,
   #[strum(to_string = "Simplified Chinese")]
   ZhCn,
   #[strum(to_string = "Traditional Chinese")]
   ZhTw,
   #[strum(to_string = "Japanese")]
   Ja,
}

// input `value` is `en`
let lang = Language::from_str(value).unwrap(); // thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: VariantNotFound'

// input `value` is `English`
let lang = Language::from_str(value).unwrap(); // success

I think it means that from_str could not find the result, and I have no idea about this.

② Second, about the summarize. I noticed that the generation of the summarize commit and the title commit is based on the file diff summary. So if the file diff summary is in Chinese, the summarize commit and the title commit will be wrong. My Solution is that the file diff summary do not use the output language setting.

I want to know your suggestions. It will help me.

[zurawiki]

For 1. This link might help

https://stackoverflow.com/questions/69292362/enum-to-str-str-to-enum

Look at the parse function

For two, you bring up a good point. We might need to add another prompt at the end to translate the whole commit message for non English languages. What do you think?

[zcf0508]

Maybe we can insert a translation step here.
https://github.com/zurawiki/gptcommit/blob/main/src/actions/prepare_commit_msg.rs#L160

I'm not familiar with the prompt, but I'll give it a try.

[zurawiki]

Try making your changes in this function. Note you'll need to rebase as I did some refactoring.

gptcommit/src/summarize.rs

Lines 55 to 58 in 57747d1

	let (title, completion) = try_join!(
	self.commit_title(summary_points),
	self.commit_summary(summary_points)
	)?;

I would add the language prompt to the title and summary prompts and then add a new prompt to translate the file-level bullet points

[zcf0508]

Sorry, I have no idea about using try_join. I create a new function commit_tanslate to translate the result message.

[zurawiki]

Suggested change

	let mut message = lines.join("\n");
	message = self.commit_tanslate(&message).await?;
	let message = lines.join("\n");
	let message = self.commit_tanslate(&message).await?;

You don't need the mut :)

[zurawiki]

This looks great! As for the try_join! we could be smarter about how many round trips we need from OpenAi but we should be good for now

Note that the lint job is failing in CI

Run just fix and make sure all errors are resolved

[zcf0508]

Thanks for the review. I fixed the lint error and some typos.

[zcf0508]

Perhaps we have a new problem.

If the user has an old configuration file, do they need to delete the old one and set it up again?

[zurawiki]

The configuration files should be forward-compatible as long as we add fields and don't change default values. Do you have instructions to repro this issue?

[zcf0508]

I have only added the translation prompt and output.lang settings. I should have been overthinking it.