Skip non-.zunit files when recursing on a test directory #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to implement this check inside the directory recursion instead of inside the file check. That way, someone can still call `zunit testfile.weirdextension` and have things work. The .zunit extension requirement is only in place when doing directory recursion.
MichaelAquilina
approved these changes
Jan 4, 2020
There was a problem hiding this comment.
This seems reasonable to me. Will wait to hear what @molovo has to say before merging though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to implement this check inside the directory recursion instead of inside the file check. That way, someone can still call
zunit testfile.weirdextensionand have things work. The .zunit extension requirement is only in place when doing directory recursion.fixes #114