Skip to content

Commit

Permalink
hdmitx: clean up bad compare and dead code
Browse files Browse the repository at this point in the history
PD#150071: hdmitx: driver defect clean up:
#2
torvalds#156

Change-Id: Icf9d9d0cd112344d9981ed33171b04f744930808
Signed-off-by: Zongdong Jiao <zongdong.jiao@amlogic.com>
Signed-off-by: Yi Zhou <yi.zhou@amlogic.com>
  • Loading branch information
Zongdong Jiao authored and akiernan committed Nov 3, 2022
1 parent e0120af commit e7b989c
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/amlogic/media/vout/hdmitx/hdmi_tx_20/hdmi_tx_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2181,7 +2181,7 @@ static ssize_t show_hdcp_ver(struct device *dev,
struct device_attribute *attr, char *buf)
{
int pos = 0;
uint32_t ver = 0;
uint32_t ver = 0U;

if (check_fbc_special(&hdmitx_device.EDID_buf[0])
|| check_fbc_special(&hdmitx_device.EDID_buf1[0])) {
Expand All @@ -2203,13 +2203,10 @@ static ssize_t show_hdcp_ver(struct device *dev,
}
next: /* Detect RX support HDCP14 */
/* Here, must assume RX support HDCP14, otherwise affect 1A-03 */
if (ver == 0) {
if (ver == 0U) {
pos += snprintf(buf+pos, PAGE_SIZE, "14\n\r");
return pos;
}

/* RX NOT support HDCP */
pos += snprintf(buf+pos, PAGE_SIZE, "00\n\r");
return pos;
}

Expand Down Expand Up @@ -2247,7 +2244,7 @@ static ssize_t store_ready(struct device *dev,
{
if (strncmp(buf, "0", 1) == 0)
hdmitx_device.ready = 0;
if (strncmp(buf, "1", 1) == 1)
if (strncmp(buf, "1", 1) == 0)
hdmitx_device.ready = 1;
return count;
}
Expand Down

0 comments on commit e7b989c

Please sign in to comment.