Change test for <sys/io.h> header file#2
Closed
cerna wants to merge 2 commits intozultron:pr-299-rebasefrom
Closed
Change test for <sys/io.h> header file#2cerna wants to merge 2 commits intozultron:pr-299-rebasefrom
cerna wants to merge 2 commits intozultron:pr-299-rebasefrom
Conversation
The HAS_SYS_IO and SYS_IO_DEFINED switches were up to now dependent on the HOST architecture type (allow on all but 'arm64'). This actually caused problems on Ubuntu Focal 20.04 LTS, where libc6-dev package on 'armhf' platform does not include the <sys/io.h> file. This change use AC_CHECK_HEADER macro in Autoconf script to determine if the system has or has not the header. Patch includes minimal change to the build-flow (i.e. does not care if this is the best macro for the task, only to cause the least amount of ripple).
Owner
|
Oh, I'm sorry, I didn't see this when I came up with my own version that did basically the same thing! I think this is the correct approach. |
zultron
force-pushed
the
pr-299-rebase
branch
2 times, most recently
from
21a2d2c to
8edde13
Compare
Author
We are not five, we are not collecting points for Mrs. Kindergarten Teacher, it doesn't matter whose commit is actually merged (and yours is actually much better). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve the test failure in machinekit#303