-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
help: Remove mobile instructions for features not in Flutter app launch. #34887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
help: Remove mobile instructions for features not in Flutter app launch. #34887
Conversation
Hello @zulip/server-user-docs members, this pull request was labeled with the "area: documentation (user)" label, so you may want to check it out! |
a1843a8
to
4412ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! Small comments below.
When this is merged, I can go through the merged commits adding comments on the zulip-flutter issues like:
When this feature is complete, we should add it back to the Help Center docs. We removed the legacy-app entry for this feature in [commit].
You can choose how messages are automatically marked as read in the Zulip web | ||
and mobile apps. You can configure the mobile app differently from the | ||
web/desktop app. | ||
app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help: Remove "Configure automatically marked as read" mobile tab.
We're actually hoping to include this feature 🤞 but we're getting down to the wire on it: #1574. I'm OK to leave this commit in for now, and we can revert if we manage to merge the feature before launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we can add that text bad in when that PR is merged. I'll make a note on the thread there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zulip/zulip-flutter#1574 is now merged, so this part can be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding a commit to #34869 for adding back this documentation, but updated for the new app's UI.
The ability to edit a channel's description is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1102 Part of zulip#34748.
The ability to edit a channel's privacy setting is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1102 Part of zulip#34748.
The ability to change the language setting is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Deletes static/images/help/mobile-chevron-left.svg as it is no longer used. This feature is tracked in: zulip/zulip-flutter#1139 Part of zulip#34748.
Updating the default channel notification setting is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#661 Part of zulip#34748.
Updating a channel's notification setting is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1223 Part of zulip#34748.
The ability to delete a topic is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1549 Part of zulip#34748.
Viewing the direct message feed is not implemented for the legacy React Native app or the Flutter app, so we remove this documentation. Part of zulip#34748.
The ability to view who reacted to a message is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#740 Part of zulip#34748.
The ability to create a channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1572 Part of zulip#34748.
The ability view and subscribe to channels is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Deletes static/images/help/mobile-plus-icon.svg as it is no longer used. This feature is tracked in: zulip/zulip-flutter#188 Part of zulip#34748.
The ability to copy a link to a topic or channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Features are tracked in: zulip/zulip-flutter#1227 zulip/zulip-flutter#792 Part of zulip#34748.
Marking unread messages as read when scrolling is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Features are tracked in: zulip/zulip-flutter#81 Part of zulip#34748.
The notifications panel (for testing, troubleshooting, and updating settings for mobile notifications) has not yet been implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. These features are generally tracked in: zulip/zulip-flutter#323 zulip/zulip-flutter#1194 zulip/zulip-flutter#661 Part of zulip#34748.
The ability to mute or unmute a channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Features are tracked in: zulip/zulip-flutter#347 Part of zulip#34748.
The ability to pin or unpin a channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Features are tracked in: zulip/zulip-flutter#1223 Part of zulip#34748.
The ability to view who as read a message is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#667 Part of zulip#34748.
The ability to edit a channel's name is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1102 Part of zulip#34748.
The ability to "share to Zulip" from Android apps is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#52 Part of zulip#34748.
The ability to add a link to a video call is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Deletes static/images/help/mobile-video-icon.svg as it is no longer used. This feature is tracked in: zulip/zulip-flutter#1000 Part of zulip#34748.
The ability to view, set, edit a user's status, or to toggle invisible mode are not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Deletes static/images/help/mobile-x-icon.svg as it is no longer used. This feature is tracked in: zulip/zulip-flutter#197 zulip/zulip-flutter#198 zulip/zulip-flutter#1578 Part of zulip#34748.
The ability to subscribe users to a channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. This feature is tracked in: zulip/zulip-flutter#1222 Part of zulip#34748.
The ability to unsubscribe from a channel is not yet implemented for the initial launch of the Flutter mobile app, so we remove the legacy React Native app instructions. Deletes static/images/help/mobile-check-icon.svg as it is no longer used. This feature is tracked in: zulip/zulip-flutter#1224 Part of zulip#34748.
4412ab7
to
5ce55ac
Compare
OK I made the batch of requested edits for this and merged, thanks @laurynmm and @chrisbobbe for all the work on this! |
These files are no longer in use due to the combined changes of the updates for the Flutter app launch: zulip#34869 and zulip#34887.
Part of #34748 and zulip/zulip-flutter#715.
Notes:
Diff of changes to help center docs
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: