___Fix focus index before and after search #976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: Label "PR review needed" does not exist and was thus not added to this pull request. |
|
@zulipbot add "PR needs review" |
|
@Rohitth007 I gave this a quick try and I agree that this resolves the issue. However, as per my message on the stream, I'd prefer to block the user from entering into an empty list, which is what we currently allow and the PR appears to continue to allow, but working around the bug? I'm certainly open to merging something like this if we have no other work on the bug prior to a release, but I'd also prefer to see the improved UI instead as it's much less confusing for the user. |
Rohitth007
changed the title
Rohitth007
changed the title
Rohitth007
changed the title
Rohitth007
changed the title
This commit corrects what the code for focus_index_before_search was intended to do. The focus index was still being updated even in the search results. This is fixed by adding a boolean `in_search_mode` which does not call `get_focus` untill the search is over. Slight reordering was done in `__init__` to fit the boolean in an ideal place w.r.t. readability. Fixes zulip#975
Rohitth007
force-pushed
the
search-mode-bug-#923
branch
from
b1012d9 to
0868e44
Compare
Rohitth007
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects what the code for
focus_index_before_searchwas intended to do. See #975The focus index was still being updated even in the search results.
This is fixed by adding a boolean
in_search_modewhich does notcall
get_focusuntill the search is over. Slight reordering wasdone in
__init__to fit the boolean in an ideal place w.r.t.readability.
Fixes #975