Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clarify draft types & naming #924

Merged

Commits on Feb 15, 2021

  1. refactor: api_types/core/model/ui/boxes: Clarify draft types & naming.

    Previously a draft was a Message, which is a much more complex data
    structure received from the server with differently-named fields. The
    draft system only requires the data which is subsequently sent via
    the send_message API call, so a simpler API-specific set of data
    structures are created and used for drafts named ~ Composition.
    
    Other than typing, the new data structures allow space to define where
    we wish to move to use newer API forms (ids vs strings) in future. An
    extra 'stream_id' field is present in StreamComposition, not present in
    the API, until we migrate to use IDs.
    
    To emphasize the message/draft distinction and migration, variable names
    are also updated to match.
    neiljp committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    15199e6 View commit details
    Browse the repository at this point in the history