-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: New user tutorial #221 #922
Conversation
e02edd4
to
cc4ade6
Compare
6384c44
to
9af64f6
Compare
I've been trying to tidy up my commit history as it involves lots of commits for typo fixes and such...this has caused me to have to force push my branch. Is this the right way to do this? I feel like I'm doing something wrong here. |
9af64f6
to
5ffad11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @klfoulk16! I've just used this guide to get acquainted with zulip-term, and everything worked!
@pilgrim2308 has already mentioned the few typos I noticed.
Also, I'd second @neiljp's idea to squash all these commits into one; it's probably what I'd do in zulip-mobile. It's sensible to use separate commits while working on it—I see that they represent progressively complete drafts that all lead to the final draft—but I expect future developers reading this file's history will be much more interested in the work as a whole, than in the progress marked in each non-final draft. 🙂 What do you think?
To send a PM: | ||
1. Type <kbd>x</kbd> from anywhere in Zulip Terminal. A message editor will pop open at the bottom of the middle column. | ||
2. Type in part of the name of the person you'd like to send a PM to (IMG 1) | ||
3. Press <kbd>ctrl</kbd><kbd>f</kbd> and a list of potential recipients will appear in the footer (highlighted in red). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Press ctrlf and a list of potential recipients will appear in the footer (highlighted in red).
I ran into an issue where this list didn't show up; the footer just stayed like this:
But then I saw a recent discussion on CZO and thought I'd try grabbing the app from current main
(instead of the latest released version) to see if the issue was fixed…
…and it was! 🎉 So, no problem here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, today I learned that you can use <kbd>x</kbd>
and GitHub will render something that looks like a keyboard key: x. Neat, thanks for that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's OK to have the tutorial be consistent with an unreleased version, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's OK to have the tutorial be consistent with an unreleased version, then?
Hmm, good question. For purely ZT-developer-facing documentation (which is most or all of zulip-mobile's documentation, I guess), I wouldn't hesitate, because it's a safe assumption that developers are working on the latest main
or at least can get there pretty easily (I used the Installation -> Latest
part of the README).
zulip/zulip.git keeps plenty of user-facing documentation, so I looked there for some clues. I see a few commits (zulip/zulip@160cc5120, zulip/zulip@1d5aa2e51) where some functionality changes, and the user-facing doc is updated simultaneously. So, for some time, the user-facing doc on GitHub is inconsistent with any released version.
…but this turns out to not be a problem for that project, because the most natural way for a user to access the doc isn't through GitHub, but through the Zulip installation itself, where, if all goes to plan, the documentation will be precisely aligned with everything else. E.g., for CZO, you'd go to https://chat.zulip.org/help/; or, for the Recurse Center, https://recurse.zulipchat.com/help/.
In ZT's case, GitHub is the place a user goes for user-facing documentation like this tutorial, and GitHub naturally shows the latest code, which is often unreleased. Hmm.
I guess I don't have a definite answer. I suppose one solution would be to point users to a published website for user-facing documentation, and have it default to the latest stable release while allowing them to select something else. Like React Native:
But that seems like a lot of effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I guess, the more frequently releases get made, the less one has to think about an inconsistency like this being a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other thoughts:
- the released version could link to version of the doc at a particular commit/tag (release)?
- we could include the
docs/
folder in the release? - the tutorial could even be accessed in the application - though images wouldn't work (text snapshots could be interesting)
docs/getting-started.md
Outdated
@@ -1,21 +1,162 @@ | |||
Hi, are you new to [Zulip](https://github.com/zulip/zulip)? If so, we recommend trying out our [web-client](https://chat.zulip.org) first to understand the concept of [streams/topics/PMs](https://zulip.com/help/about-streams-and-topics) in the world of Zulip. Just sending a message or two in [#test here](https://chat.zulip.org/#narrow/stream/7-test-here) stream should help you get started. | |||
Hi, are you new to [Zulip](https://github.com/zulip/zulip)? If so, I recommend trying out our [web-client](https://chat.zulip.org) first to understand the concept of [streams/topics/PMs](https://zulip.com/help/about-streams-and-topics) in the world of Zulip. Just sending a message or two in [#test here](https://chat.zulip.org/#narrow/stream/7-test-here) stream should help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I almost forgot—along with the link to CZO (chat.zulip.org), I think it'd be good to link to the CZO community doc, which has lots of useful information that we'd like people to be aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the plug in the first paragraph
5ffad11
to
a2f8815
Compare
Thanks for all the comments! I went through and fixed everything. As for the autocomplete...I left it in the tutorial but I made clear that you need to be using the version from Github (as opposed to the stable release). I also added more information about how to send PMs other ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klfoulk16 I've left quite a few points, thought these are not all directly applicable to the document/PR itself. I think this will really help people get started 👍
docs/getting-started.md
Outdated
You can also send a PM by moving your cursor to the list of "Users" in the left column and selecting the name of the person you'd like to send a message to. | ||
|
||
### Send a PM with the New Autocomplete Feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These feel like two parts of the same feature - starting a private conversation with someone new?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the "Send a PM" and "Send a PM with the New Autocomplete Feature" sections? I do I feel like we could get rid of the "Send a PM with the New Autocomplete Feature" section as it is a bit repetitive. It could be better suited as a mini tutorial to explain how to use new features? If we removed this section it would also resolve the issue of potentially having to link the tutorial to a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that linking to the tutorial somewhere in the help menu or maybe have a keyboard shortcut that opens the tutorial could be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed this now, but yes I think I meant those two sections felt like one section.
I think we should handle the tutorial/release synchronization issue separately.
Is your last comment regarding my response elsewhere in the PR about using the tutorial source at run-time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini 'feature tutorials' could go in the FAQ document, and we could link from the README and maybe at the end of the tutorial to a list of "things you might try exploring next"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup my last commend was in regards to your response elsewhere in the PR about using the tutorial source at run-time. I'll link to the FAQ at the end. I think for now the section about sending a PM can stay in this tutorial, I think it flows well.
To send a PM: | ||
1. Type <kbd>x</kbd> from anywhere in Zulip Terminal. A message editor will pop open at the bottom of the middle column. | ||
2. Type in part of the name of the person you'd like to send a PM to (IMG 1) | ||
3. Press <kbd>ctrl</kbd><kbd>f</kbd> and a list of potential recipients will appear in the footer (highlighted in red). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other thoughts:
- the released version could link to version of the doc at a particular commit/tag (release)?
- we could include the
docs/
folder in the release? - the tutorial could even be accessed in the application - though images wouldn't work (text snapshots could be interesting)
|
||
## Create a New Topic | ||
|
||
To create a new topic in a stream, type <kbd>c</kbd> and a message editor will pop open at the bottom of the middle column. Make sure your cursor is in the middle column, otherwise nothing will happen when you type <kbd>c</kbd>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pertinent to the tutorial right now, but do you think we should support this working in the stream or topic list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do feel like it's a bit confusing how it works in the middle column but nowhere else. Considering how the c key isn't repurposed for something else in other sections, I think it would be nice if the c key was consistent across ZT
a2f8815
to
b47dce4
Compare
I decided I should remove the extra information about reactions and keep it short and sweet (the extra text was fairly verbose and intuitive)...let me know if you disagree and I'll add it back: Reactions for a message will be displayed right below it, such as the "thumbs-up" reaction in the screenshot below. The number beside a reaction is the number of people who sent that reaction (currently it's 1). The fact that the reaction is highlighted pink means that we sent that reaction. The colors of reactions sent by others will be inverted (notice how the text is pink and the highlight is none for the reactions "octopus" and "+1" a few messages down). |
c08db94
to
225a0f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klfoulk16 This is looking really great 👍
We could iterate on variations to the text, but this seems very close to ready. Some of the things that stand out for me are:
- Making the images more polished - mostly as we discussed. The smaller images already help, and when the text in them is larger (ie. fewer rows/columns) then that will too. I mentioned whether you want to use a demo/bot user for the screenshots in the stream. Also I wasn't sure if you had particular refinements planned regarding the annotations - do you have multilayer images which you're converting to the final versions, to explore different annotations? I don't think we need particularly polished versions initially, particularly if we have the originals to work with.
- Adding some emphasis on signing up for an account on chat.zulip.org (or some other server) early on "Ensure you have an account / sign up", to ensure the "learning by doing" can take place, given that users can't sign up using zulip-terminal yet.
Other than that, you've resolved some comments - but I'm not sure if the related version is pushed to the PR branch yet? eg. regarding one title level, the verb/noun splitting, etc.
I'd like to get the next iteration out for external review again, as it'd be good to hear from new users' :)
docs/getting-started.md
Outdated
|
||
Let's try editing the new topic we added to the [# test here](https://chat.zulip.org/#narrow/stream/7-test-here) stream. By default, Zulip allows you to edit the content of your messages within 10 minutes of when you send them. | ||
|
||
To edit a message, first make sure your cursor is resting on the message you want to edit then type <kbd>e</kbd>. You can edit the message's content, topic or stream. By default your cursor will be in the content portion of the message, press <kbd>tab</kbd> to move it to the stream or topic portion if you'd like to edit those as well. Change whatever you'd like to change, then type <kbd>ctrl</kbd><kbd>d</kbd> to update the message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth noting the equivalence to the sending key, or that may be confusing?
We could briefly mention that this (and deleting) normally leave the previous edition(s) available (with a potential link to "extra things to explore - message info -> edit history"?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I had no idea there was a way to view previous versions of a message. I see a tutorial for how to do this on Zulip, but is it possible to do this on ZT? Right now I've linked to the Zulip tutorial about it. I think explaining how is outside the scope of this tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we support this right now with i
on a message, and if there is history you can show that using e
.
225a0f1
to
fbb4798
Compare
@klfoulk16 We're discussing the images still, but I think we're good to get more feedback? @chrisbobbe Would you be up for taking another look, if you haven't been following along? Follow-up work that comes to mind: (please chip in with other ideas if you have them!)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @klfoulk16!
Would you be up for taking another look, if you haven't been following along?
Sure!
I've just gone through it again, and overall it still looks great! I've added a few small comments below (sorry if some of the points already have discussions that I missed 🙂).
docs/getting-started.md
Outdated
|
||
If you have issues opening Zulip Terminal, check out our [Running for the First Time](https://github.com/zulip/zulip-terminal#running-for-the-first-time) section. | ||
|
||
*Note: This tutorial assumes you're on the Zulip Community Server. While you can still follow along if you're not, various examples won't be the same (such as the [# test here](https://chat.zulip.org/#narrow/stream/7-test-here) stream).* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is there a reason to put a space between "#" and the stream name, as in "# test here"? I'm used to there not being a space there, but I see the space has been used several times, including in at least one of the images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I always felt like there was a space there (kinda looks like it in the desktop app and ZT). I think the person who originally started this tutorial had a space there so I continued that syntax
docs/getting-started.md
Outdated
|
||
Let's try editing the new topic we added to the [# test here](https://chat.zulip.org/#narrow/stream/7-test-here) stream. By default, Zulip allows you to edit the content of your messages within 10 minutes of when you send them, but some servers allow you to edit messages for longer. You can edit message content for up to one hour after sending on the Zulip Community server. | ||
|
||
To edit a message, first make sure your cursor is resting on the message you want to edit then type <kbd>e</kbd>. You can edit the message's content, topic or stream. By default your cursor will be in the content portion of the message, press <kbd>tab</kbd> to move it to the stream or topic portion if you'd like to edit those as well. Change whatever you'd like to change, then press <kbd>ctrl</kbd><kbd>d</kbd> to submit the updated message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can edit the message's content, topic or stream.
Huh, interesting; @neiljp, when it says you can edit the stream of a message, is this the relatively new "move topics between streams" feature? Hmm, but IIUC #826 suggests that that feature isn't yet fully handled. So I guess I'm not totally sure what's meant to happen if you edit the stream. 🙂
As one data point, I tried editing the stream of a message in #test here
, so its stream would instead be a different one, a private one I had made months ago for some testing.
I confirmed in the web app that the message remained in #test here
, and no new message appeared in the private stream. The message's edit history in the web app looks like this:
88a1a72
to
6061446
Compare
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klfoulk16 This looks great! I've left a few points, but really they're just polish which we could add later.
We can move the developer notes at the bottom into a markdown comment right at the top of the the document?
We didn't get a conclusion on the space in '# test here' though?
I'd be happy to hear from @chrisbobbe again, or others, or look to merge :)
6061446
to
c81b6d8
Compare
The existing tutorial for new users was incomplete. We decided to improve, expand and complete it. Images for the tutorial are in docs/getting-started-imgs. Fixes zulip#221.
c81b6d8
to
55a2d90
Compare
Tackled all your comments and fixed the odd # test here space. I think it's ready! |
@klfoulk16 Thanks again for all your work on this! I pushed a slightly updated version temporarily to https://github.com/neiljp/zulip-terminal/blob/review-original-922/docs/getting-started.md - you can check the latest commit there for the few changes I made on top, but other than some minor textual changes, the biggest net effect was using This is in my merge queue based on that version, so let me know if I've missed anything or you have any last-minute thoughts :) |
I just read through it and everything sounds/looks great! That's awesome you were able to compress the images that much! I should have thought of that. |
@klfoulk16 Thanks again! Merged 🎉 |
docs: Create outline for new user tutorial.