bugfix: boxes: Ensure self-message recipient_ids are a list. #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
added
the
PR ready to be merged
Setting the type of the input model in MessageBox initializer correctly should ensure that this is picked up in future by mypy.
neiljp
force-pushed
the
2021-02-02-ensure-self-messages-are-a-list
branch
from
21f6e2b to
40e8047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the type of the input model in MessageBox initializer correctly should ensure that this is picked up in future by mypy.
@prah23 I noticed this issue when reviewing #877 and isolated it to being a separate issue.
One deeper optimization we could make is not to send the typing status if it's a self-message, but it seems to be OK right now.