Refactor run.py with DEFAULT_SETTINGS & simple error exits #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a refactor, but also updates the help text for the color-depth and theme.
neiljp
force-pushed
the
2021-01-26-simplify-run-with-841-pt1
branch
2 times, most recently
from
0bbe9f7 to
0bac50e
Compare
Errors are now specified as: * the main error string (to be styled red) * an optional extra text (unstyled, default empty string) * an optional error code (default 1) This is mostly a refactor, but some behavior without fixed tests is improved with regard to newlines and text. Tests added. Co-authored-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
neiljp
force-pushed
the
2021-01-26-simplify-run-with-841-pt1
branch
from
0bac50e to
5b558ad
Compare
|
@Abhirup-99 Thanks for your initial work on that commit - good motivation to get this file more organized 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #841 with some extra work and a few other commits first to help application of that refactor, and to extract DEFAULT_SETTINGS into a central place.
@Abhirup-99 Happy to take feedback :)