[WIP] Avoid inserting topics into topic search list unless relevant #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the intent of the function, the filtering of the topics that occurs from the search box, compared to simply 'updating' it, which is less clear and currently very similar to the adjacent update_topics_list. Tests amended.
Use two intermediate variables to improve code readability.
FIX/UPDATE/REDO TESTS.
However, be sure to do the operation on the un-filtered (non-search) list, for when search is exited. Fixes zulip#661.
|
Heads up @neiljp, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the view update (originally by @sumanthvrao) on pushing newer topics to the top of the topic list, making the logic cleaner.
The final commit fixes #661.
NOTES:
Feedback welcome