Migrate to minimum of python3.6 (aka remove python3.5) #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
neiljp
force-pushed
the
2020-11-29-python3.6-minimum
branch
from
3e6d29b to
d21f342
Compare
Python 3.5 reached end of line in mid September 2020. This removes: * testing 3.5 in linting GitHub Action CI (bump isort to run w/3.6) * labelled python version support in setup.py for 3.5 * pinning of zipp package (was required to support python 3.5) * hiding a pytest warning for python 3.5 unrelated to zulip-terminal The noted minimum version in README.md is also updated.
With the removal of support for python 3.5, there is no reason not to upgrade isort beyond 4.3.21. For now we loosely pin to 5.6.*. With this change the recursive option becomes the default, so the linting script and makefile are updated accordingly; the feedback text is also updated. This change requires a minor change to setup.py, and extends the isort coverage to all of tools/, so also updates the formatting of another script.
Automated by application of fstringify to zulipterminal/
neiljp
force-pushed
the
2020-11-29-python3.6-minimum
branch
from
d21f342 to
763bb7e
Compare
Many cases found using pyupgrade; others manually, leading to some unnecessary adjacent .format usage also being removed. Some string addition also removed. Standardized on double-quotes where code meaning not changed.
This format is enabled by running with only python 3.6+. The pyupgrade tool enables some of this work, but needed manual porting of comments and failed for false-totality TypedDicts.
neiljp
force-pushed
the
2020-11-29-python3.6-minimum
branch
from
763bb7e to
9db81f0
Compare
neiljp
changed the title
|
The last planned bullet-point for this PR is now listed separately in #901. Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status so far:
TypedDicts to class syntax