Autocomplete with exact matches in stream & topic compose boxes #823
Conversation
zulipbot
added
size: S
neiljp
force-pushed
the
2020-11-08-explore-readline-delims
branch
from
aafa7d3 to
fc614ca
Compare
This allows use of the new/fixed support for using no autocomplete delimiters, ie. doing an exact match of text in a text box.
Given urwid-readline 0.12, this allows an exact match on the text in the box, avoiding situations where eg. spaces in names could give rise to duplicates of the first words after backspacing from valid or partial text and autocompleting. Tests updated (2 xfails removed). Fixes zulip#776.
neiljp
force-pushed
the
2020-11-08-explore-readline-delims
branch
from
fc614ca to
d4cc1b7
Compare
neiljp
added
the
PR ready to be merged
|
I've tidied The previous iteration also didn't update the dependency in requirements.txt and Pipfile, which this now does.
|
There was a problem hiding this comment.
@neiljp This looks good!
We'd also want to incorporate this with the normal typeahead in the compose box?
|
@kaustubh-nair That would be another project/issue, as we can't just have no delimiters like here, as we'd match the entire box again. The logic available in the library may replace some of what we have already, but we may be able to dynamically set the autocomplete-delimiters, as long as we remember to reset them! If you follow what I'm saying, please open an issue to describe what could be done so we don't forget :) I'll merge this now. |
This should partially or fully fix #776, but is pending on https://github.com/rr-/urwid_readline/pull/16 and assumes there will be a release of urwid-readline. For now my branch can be used to test this behavior; this allows 2 xfail-ing tests to be set to act normally.