bugfix: ui: Do not update footer if new text is same as current. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: S
|
This is an alternative to #725 |
This prevents rapid footer updates if an error message is triggered multiple times. An example of this would be a user holding-down/pressing too often the edit message key on a message that cannot be edited. This fix does not account for updates that might happen for different messages, but we can safely assume that the time difference between such messages would not be too small and such a bug would most likely not occur. Test added. Fixes zulip#647. Comment & slight adjustment by neiljp.
neiljp
force-pushed
the
rapid-footer-updates-v2
branch
from
5c631d9 to
f3d878f
Compare
neiljp
added
PR ready to be merged
|
@kaustubh-nair Rebased and merged this great simple fix with minor tweaks, thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents rapid footer updates if an error message is triggered
multiple times. An example of this would be a user holding-down/pressing
too often the edit message key on a message that cannot be edited.
This fix does not account for updates that might happen for different
messages, but we can safely assume that the time difference between such
messages would not be too small and such a bug would most likely not
occur.
Test added.
Fixes #647.