Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '•' in front of active senders #501

Closed
wants to merge 1 commit into from

Conversation

yashlamba
Copy link

No description provided.

@zulipbot zulipbot added the size: S [Automatic label added by zulipbot] label Feb 5, 2020
@zulipbot
Copy link
Member

Heads up @yashlamba, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@Ezio-Sarthak
Copy link
Member

Ezio-Sarthak commented Jan 14, 2021

Thanks for working on this! This should be sufficient as v0 for #406 👍
yashlamba this shouldn't be much messy while rebasing. Are you planning to push this?

[minor]: It's always good to mention the issue for which a PR is created (either in commit/PR message text) :)

@yashlamba
Copy link
Author

@Ezio-Sarthak Thanks for reviewing this, we had a discussion about this earlier when I opened this PR. The result wasn't sufficing (Can't exactly remember what changes were suggested) and I got busy with other stuff. I won't mind if anyone else wants to continue over this.

@neiljp
Copy link
Collaborator

neiljp commented Jan 28, 2021

Note that this is not really about fixing #406, so I opened #896 for this.

Base automatically changed from master to main January 30, 2021 20:30
@neiljp
Copy link
Collaborator

neiljp commented Feb 28, 2022

@yashlamba I believe this has been fulfilled by the now-merged #987, so am going to close this now. Please comment/re-open if you feel this is incorrect! (or call in to #zulip-terminal of course)

@neiljp neiljp closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants