Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor Narrow structure #1375

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Refactor Narrow structure #1375

wants to merge 4 commits into from

Commits on Apr 9, 2023

  1. model: Add function to expose narrow to other files. 

    This commit contains get_narrow() and get_narrow_length()
which are used to provide data inside narrow and length of narrow
respectively to other components of the codebase.
    @mounilKshah
    mounilKshah committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    455ced7 View commit details
    Browse the repository at this point in the history

  2. helper: Replace direct access to Model.narrow with functions. 

    This commit replaces all instances where Model.narrow is directly
used with usage of functions Model.get_narrow() and
Model.get_narrow_length() in order to limit direct access to Model.narrow
to Model class.
    @mounilKshah
    mounilKshah committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    b49335f View commit details
    Browse the repository at this point in the history

  3. messages: Replace direct access to Model.narrow with functions. 

    This commit replaces all instances which directly access Model.narrow
with usage of functions Model.get_narrow() and Model.get_narrow_length()
to restrict access to narrow data structure to only Model class.
    @mounilKshah
    mounilKshah committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    5c3228b View commit details
    Browse the repository at this point in the history

  4. utils: Replace direct access to Model.narrow with functions. 

    This commit replaces all instances of direct usage of Model.narrow
with respective functions.
    @mounilKshah
    mounilKshah committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    2924a28 View commit details
    Browse the repository at this point in the history