Upgrade to mypy 1.0.0 after incompatible typeshed change #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary since fresh environment builds (including CI) appear to pull a version of types-requests that is broken with mypy < 1.0, types-requests being the broken-out 3rd-party package of stubs for requests, but that is still maintained in typeshed. This appears to be python/typeshed#9702. The mypy version is updated to ~=1.0.0 versioning now that it has moved to a major/minor/point versioning scheme.
neiljp
added
PR blocks other PR
PR ready to be merged
One of these are required by the upgrade of mypy to version 1.0.0, which flags an unnecessary type-ignore as an error. The other case is a second type-ignore that can be removed via explicitly typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps mypy version to 1.0.0 and makes minor changes to remove some type ignores, one of which caused a linting error.
The commits are structured to bump mypy first, since it seems that lots of type stubs became incompatible with mypy < 1.0 in python/typeshed#9702, which I assume translated into an incompatible
types-requests. This translates into 2Self?-related errors in ZT, maybe more elsewhere.The second commit then makes some minor adjustments to take into account the mypy bump. These are only typing changes (or ignore-comments) so should not substantively affect the code running, though arguably they do fix the previous commit. I'm keeping them separate for clarity.
Tested?