Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper: Sync unread pm message count in all_pms and user button count. #1000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkp6781
Copy link
Contributor

@mkp6781 mkp6781 commented Apr 20, 2021

User buttons list is updated using update_user_list before count of user
buttons is modified in _set_count_in_view. Now, we do not have to wait
for the presence update before displaying the correct unread count.

Fixes #438

User buttons list is updated using `update_user_list` before count of user
buttons is modified in `_set_count_in_view`. Now, we do not have to wait
for the presence update before displaying the correct unread count.
@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Apr 20, 2021
@zulipbot
Copy link
Member

Hello @mkp6781, it seems like you have referenced #438 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #438..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

@mkp6781
Copy link
Contributor Author

mkp6781 commented Apr 30, 2021

@zulipbot add "PR needs review"

@zulipbot zulipbot added the PR needs review PR requires feedback to proceed label Apr 30, 2021
@zulipbot
Copy link
Member

Heads up @mkp6781, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts PR needs review PR requires feedback to proceed size: XS [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync unread counts of PMs between All_pm_Button and the respective user button.
2 participants