internalLinks: Recognize "channel" as operator in narrow links #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor will help with zulip#5861, but Tim has reminded me that we're not ready to address zulip#5861 until a release addressing zulip#5860 (as we did in the previous commit) has been out for a while: https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1786615
chrisbobbe
added
P1 high-priority
webapp parity
gnprice
reviewed
Apr 25, 2024
Comment on lines
-141
to
+154
| eg.makeStream({ name: 'jest' }), | ||
| eg.makeStream({ name: 'stream' }), | ||
| eg.makeStream({ name: 'topic' }), | ||
| eg.makeStream({ name: 'mobile' }), | ||
| eg.makeStream({ stream_id: 1, name: 'jest' }), | ||
| eg.makeStream({ stream_id: 2, name: 'stream' }), | ||
| eg.makeStream({ stream_id: 3, name: 'topic' }), | ||
| eg.makeStream({ stream_id: 4, name: 'mobile' }), |
There was a problem hiding this comment.
Hmm interesting — why do these become newly needed?
| @@ -172,6 +189,16 @@ describe('getNarrowFromNarrowLink (part 1)', () => { | |||
| // TODO: Test with modern-style stream links that use stream IDs | |||
There was a problem hiding this comment.
I guess it's because we're effectively doing this at the same time.
Sure, seems fine given this is a legacy codebase we don't want to spend too much effort polishing.
There was a problem hiding this comment.
Yeah, that's right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5860