Skip to content

action sheets [nfc]: Factor out makeButtonCallback. #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2021
Merged

action sheets [nfc]: Factor out makeButtonCallback. #4566

merged 1 commit into from
Mar 27, 2021

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Mar 26, 2021

This deduplicates a bit of code, notably the try/catch and the alert on error.

A small followup to #4541 (review) .

@gnprice
action sheets [nfc]: Factor out makeButtonCallback.
1be366b 
This deduplicates a bit of code, notably the try/catch and the
alert on error.
@gnprice gnprice requested a review from WesleyAC March 26, 2021 22:52
@gnprice gnprice mentioned this pull request Mar 26, 2021
Merged
WesleyAC
WesleyAC approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@WesleyAC WesleyAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice! I didn't think to pass in the entire Args object when I was writing this, that makes sense.

@WesleyAC WesleyAC merged commit 50d6d10 into zulip:master Mar 27, 2021
@gnprice gnprice deleted the pr-makebuttoncallback branch April 1, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@WesleyAC WesleyAC WesleyAC approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnprice @WesleyAC