Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ComposeBox message and topic inputs uncontrolled #2738

Merged
merged 4 commits into from
Jun 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
382 changes: 382 additions & 0 deletions src/compose/ComposeBox.android.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,382 @@
/* @flow */
import React, { PureComponent } from 'react';
import { View, TextInput, findNodeHandle } from 'react-native';
import { connect } from 'react-redux';
import TextInputReset from 'react-native-text-input-reset';
import isEqual from 'lodash.isequal';

import type {
Auth,
Context,
Narrow,
EditMessage,
InputSelectionType,
User,
Dispatch,
Dimensions,
GlobalState,
} from '../types';
import {
addToOutbox,
cancelEditMessage,
draftAdd,
draftRemove,
fetchTopicsForActiveStream,
sendTypingEvent,
} from '../actions';
import { updateMessage } from '../api';
import { FloatingActionButton, Input, MultilineInput } from '../common';
import { showErrorAlert } from '../utils/info';
import { IconDone, IconSend } from '../common/Icons';
import { isStreamNarrow, isStreamOrTopicNarrow, topicNarrow } from '../utils/narrow';
import ComposeMenu from './ComposeMenu';
import AutocompleteViewWrapper from '../autocomplete/AutocompleteViewWrapper';
import getComposeInputPlaceholder from './getComposeInputPlaceholder';
import NotSubscribed from '../message/NotSubscribed';

import {
getAuth,
getSession,
canSendToActiveNarrow,
getLastMessageTopic,
getActiveUsersAndBots,
getShowMessagePlaceholders,
} from '../selectors';
import { getIsActiveStreamSubscribed } from '../subscriptions/subscriptionSelectors';
import { getDraftForActiveNarrow } from '../drafts/draftsSelectors';

type Props = {
auth: Auth,
canSend: boolean,
narrow: Narrow,
usersAndBots: User[],
draft: string,
lastMessageTopic: string,
isSubscribed: boolean,
editMessage: EditMessage,
safeAreaInsets: Dimensions,
dispatch: Dispatch,
messageInputRef: (component: any) => void,
};

type State = {
isMessageFocused: boolean,
isTopicFocused: boolean,
isMenuExpanded: boolean,
topic: string,
message: string,
height: number,
selection: InputSelectionType,
};

export const updateTextInput = (textInput: TextInput, text: string): void => {
if (!textInput) {
// Depending on the lifecycle events this function is called from,
// this might not be set yet.
return;
}

textInput.setNativeProps({ text });

if (text.length === 0 && TextInputReset) {
// React Native has problems with some custom keyboards when clearing
// the input's contents. Force reset to make sure it works.
TextInputReset.resetKeyboardInput(findNodeHandle(textInput));
}
};

class ComposeBox extends PureComponent<Props, State> {
context: Context;
props: Props;
state: State;

messageInput: TextInput = null;
topicInput: TextInput = null;

static contextTypes = {
styles: () => null,
};

state = {
isMessageFocused: false,
isTopicFocused: false,
isMenuExpanded: false,
height: 20,
topic: '',
message: this.props.draft,
selection: { start: 0, end: 0 },
};

getCanSelectTopic = () => {
const { isMessageFocused, isTopicFocused } = this.state;
const { editMessage, narrow } = this.props;
if (editMessage) {
return isStreamOrTopicNarrow(narrow);
}
if (!isStreamNarrow(narrow)) {
return false;
}
return isMessageFocused || isTopicFocused;
};

setMessageInputValue = (message: string) => {
updateTextInput(this.messageInput, message);
this.handleMessageChange(message);
};

setTopicInputValue = (topic: string) => {
updateTextInput(this.topicInput, topic);
this.handleTopicChange(topic);
};

handleComposeMenuToggle = () => {
this.setState(({ isMenuExpanded }) => ({
isMenuExpanded: !isMenuExpanded,
}));
};

handleLayoutChange = (event: Object) => {
this.setState({
height: event.nativeEvent.layout.height,
});
};

handleTopicChange = (topic: string) => {
this.setState({ topic, isMenuExpanded: false });
};

handleTopicAutocomplete = (topic: string) => {
this.setTopicInputValue(topic);
};

handleMessageChange = (message: string) => {
this.setState({ message, isMenuExpanded: false });
const { dispatch, narrow } = this.props;
dispatch(sendTypingEvent(narrow));
};

handleMessageAutocomplete = (message: string) => {
this.setMessageInputValue(message);
};

handleMessageSelectionChange = (event: Object) => {
const { selection } = event.nativeEvent;
this.setState({ selection });
};

handleMessageFocus = () => {
const { topic } = this.state;
const { lastMessageTopic } = this.props;
this.setState({
isMessageFocused: true,
isMenuExpanded: false,
});
setTimeout(() => {
this.setTopicInputValue(topic || lastMessageTopic);
}, 200); // wait, to hope the component is shown
};

handleMessageBlur = () => {
setTimeout(() => {
this.setState({
isMessageFocused: false,
isMenuExpanded: false,
});
}, 200); // give a chance to the topic input to get the focus
};

handleTopicFocus = () => {
const { dispatch, narrow } = this.props;
this.setState({
isTopicFocused: true,
isMenuExpanded: false,
});
dispatch(fetchTopicsForActiveStream(narrow));
};

handleTopicBlur = () => {
setTimeout(() => {
this.setState({
isTopicFocused: false,
isMenuExpanded: false,
});
}, 200); // give a chance to the mesage input to get the focus
};

handleInputTouchStart = () => {
this.setState({ isMenuExpanded: false });
};

handleSend = () => {
const { dispatch, narrow } = this.props;
const { topic, message } = this.state;

const destinationNarrow = isStreamNarrow(narrow)
? topicNarrow(narrow[0].operand, topic || '(no topic)')
: narrow;

dispatch(addToOutbox(destinationNarrow, message));
dispatch(draftRemove(narrow));

this.setMessageInputValue('');
};

handleEdit = () => {
const { auth, editMessage, dispatch } = this.props;
const { message, topic } = this.state;
const content = editMessage.content !== message ? message : undefined;
const subject = topic !== editMessage.topic ? topic : undefined;
if (content || subject) {
updateMessage(auth, { content, subject }, editMessage.id).catch(error => {
showErrorAlert(error.message, 'Failed to edit message');
});
}
dispatch(cancelEditMessage());
};

tryUpdateDraft = () => {
const { dispatch, draft, narrow } = this.props;
const { message } = this.state;

if (draft.trim() === message.trim()) {
return;
}

if (message.trim().length === 0) {
dispatch(draftRemove(narrow));
} else {
dispatch(draftAdd(narrow, message));
}
};

componentDidMount() {
const { message, topic } = this.state;

updateTextInput(this.messageInput, message);
updateTextInput(this.topicInput, topic);
}

componentWillUnmount() {
this.tryUpdateDraft();
}

componentWillReceiveProps(nextProps: Props) {
if (nextProps.editMessage !== this.props.editMessage) {
const topic =
isStreamNarrow(nextProps.narrow) && nextProps.editMessage
? nextProps.editMessage.topic
: '';
const message = nextProps.editMessage ? nextProps.editMessage.content : '';
this.setMessageInputValue(message);
this.setTopicInputValue(topic);
if (this.messageInput) {
this.messageInput.focus();
}
} else if (!isEqual(nextProps.narrow, this.props.narrow)) {
this.tryUpdateDraft();

this.setMessageInputValue(nextProps.draft);
}
}

render() {
const { styles } = this.context;
const { isTopicFocused, isMenuExpanded, height, message, topic, selection } = this.state;
const {
auth,
canSend,
narrow,
usersAndBots,
editMessage,
safeAreaInsets,
messageInputRef,
isSubscribed,
} = this.props;

if (!canSend) {
return null;
}

if (!isSubscribed) {
return <NotSubscribed narrow={narrow} />;
}

const placeholder = getComposeInputPlaceholder(narrow, auth.email, usersAndBots);

return (
<View style={{ marginBottom: safeAreaInsets.bottom }}>
<AutocompleteViewWrapper
composeText={message}
isTopicFocused={isTopicFocused}
marginBottom={height}
messageSelection={selection}
narrow={narrow}
topicText={topic}
onMessageAutocomplete={this.handleMessageAutocomplete}
onTopicAutocomplete={this.handleTopicAutocomplete}
/>
<View style={styles.composeBox} onLayout={this.handleLayoutChange}>
<View style={styles.alignBottom}>
<ComposeMenu
narrow={narrow}
expanded={isMenuExpanded}
onExpandContract={this.handleComposeMenuToggle}
/>
</View>
<View style={styles.composeText}>
{this.getCanSelectTopic() && (
<Input
style={styles.topicInput}
underlineColorAndroid="transparent"
placeholder="Topic"
selectTextOnFocus
textInputRef={component => {
this.topicInput = component;
}}
onChangeText={this.handleTopicChange}
onFocus={this.handleTopicFocus}
onBlur={this.handleTopicBlur}
onTouchStart={this.handleInputTouchStart}
/>
)}
<MultilineInput
style={styles.composeTextInput}
placeholder={placeholder}
textInputRef={component => {
if (component) {
this.messageInput = component;
messageInputRef(component);
}
}}
onBlur={this.handleMessageBlur}
onChange={this.handleMessageChange}
onFocus={this.handleMessageFocus}
onSelectionChange={this.handleMessageSelectionChange}
onTouchStart={this.handleInputTouchStart}
/>
</View>
<View style={styles.alignBottom}>
<FloatingActionButton
style={styles.composeSendButton}
Icon={editMessage === null ? IconSend : IconDone}
size={32}
disabled={message.trim().length === 0}
onPress={editMessage === null ? this.handleSend : this.handleEdit}
/>
</View>
</View>
</View>
);
}
}

export default connect((state: GlobalState, props) => ({
auth: getAuth(state),
usersAndBots: getActiveUsersAndBots(state),
safeAreaInsets: getSession(state).safeAreaInsets,
isSubscribed: getIsActiveStreamSubscribed(props.narrow)(state),
canSend: canSendToActiveNarrow(props.narrow) && !getShowMessagePlaceholders(props.narrow)(state),
editMessage: getSession(state).editMessage,
draft: getDraftForActiveNarrow(props.narrow)(state),
lastMessageTopic: getLastMessageTopic(props.narrow)(state),
}))(ComposeBox);
File renamed without changes.