Skip to content

Commit

Permalink
android build [nfc]: Add a lint-suppression line.
Browse files Browse the repository at this point in the history
Part of the RN v0.61 -> v0.62 changes to the template app [1],
corresponding to facebook/react-native@87f94d558. This may freely be
done before the upgrade commit.

This `// noinspection` line is mentioned in an obsolete Android
Studio doc on suppressing lint warnings [2]; it's not clear that it's
the best way to do what it says it does. But might as well follow
the template.

[1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2

[2] http://tools.android.com/tips/lint/suppressing-lint-warnings (be
    sure to click "stop" before the timer runs out on the automatic
    redirect)
  • Loading branch information
chrisbobbe committed Sep 1, 2020
1 parent 11fa114 commit cdd7ee6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.0.0'
implementation "com.google.firebase:firebase-messaging:17.3.4"
implementation "me.leolin:ShortcutBadger:1.1.16@aar"
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:+" // From node_modules

if (enableHermes) {
Expand Down

0 comments on commit cdd7ee6

Please sign in to comment.