test: Use random email in eg.user #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
pr-random-email
branch
from
84007a2 to
4f6f236
Compare
PIG208
force-pushed
the
pr-random-email
branch
from
4f6f236 to
7627a1b
Compare
chrisbobbe
approved these changes
Sep 13, 2024
test/example_data.dart
Outdated
| @@ -70,13 +70,21 @@ GetServerSettingsResult serverSettings({ | |||
| int _nextUserId() => (_lastUserId += 1 + Random().nextInt(100)); | |||
| int _lastUserId = 1000; | |||
|
|
|||
| /// A random email address, unique from previously generated ones. | |||
There was a problem hiding this comment.
Suggested change
| /// A random email address, unique from previously generated ones. | |
| /// A random email address, different from previously generated ones. |
chrisbobbe
added
integration review
PIG208
force-pushed
the
pr-random-email
branch
from
7627a1b to
3ee9069
Compare
This specifically fixes a test data realism issue of the test "find account among several" in `test/notifications/display_test.dart` due to duplicate email addresses within a realm. This also useful in general in cases when the email addresses do not matter and should be kept boring. The generation uses an increasing sequence to make collision unlikely (still possible with caller specified values). Signed-off-by: Zixuan James Li <zixuan@zulip.com>
|
Thanks @PIG208 for the fix, and @chrisbobbe for the previous review! Looks good; merging, with one docs tweak: -/// If `deliveryEmail` is not given, it will be generated from a random
-/// but unique sequence of strings.
+/// If `deliveryEmail` is not given, it will be generated from a
+/// random sequence of distinct strings.For me saying the sequence is unique would mean that it's distinct from other sequences; instead we mean that all its elements are unique, i.e. distinct from each other. |
gnprice
force-pushed
the
pr-random-email
branch
from
3ee9069 to
d1a2538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically fixes a test data realism issue of the test "find account among several" in
test/notifications/display_test.dartdue to duplicate email addresses within a realm. This also useful in general in cases when the email addresses do not matter and should be kept boring.The generation uses an increasing sequence to make collision unlikely (still possible with caller specified values).
This is taken from #934 and similar to #932.