Omit unread button unsubscribed #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
somehow the earlier pr for appdelgate keeps sneaking In that's why I closed it but all seems good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sorry for doing a pr on this , I already saw that someone was assigned and I saw that he hasn't done a pr yet so I am doing this basically I noticed that If store.subscriptions[message.streamId] returns null, it means the user is not subscribed to that stream. so I just fixed that , please ignore this if the pr is to be completed by the assignee Idk how this works im still learning
im doing the table thing for the first time not sure if its needed but here goes